Skip to content

Commit

Permalink
usb: gadget: renesas_usbhs: Use kcalloc instead of kzalloc to allocat…
Browse files Browse the repository at this point in the history
…e array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Thomas Meyer authored and Greg Kroah-Hartman committed Dec 10, 2011
1 parent 59bf5cf commit 8776384
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/renesas_usbhs/mod_host.c
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ int usbhs_mod_host_probe(struct usbhs_priv *priv)
return -ENOMEM;
}

pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL);
pipe_info = kcalloc(pipe_size, sizeof(*pipe_info), GFP_KERNEL);
if (!pipe_info) {
dev_err(dev, "Could not allocate pipe_info\n");
goto usbhs_mod_host_probe_err;
Expand Down

0 comments on commit 8776384

Please sign in to comment.