Skip to content

Commit

Permalink
tmspci: fix request_irq race
Browse files Browse the repository at this point in the history
Currently, tmspci tokenring driver crashes on device initialization
because it requests its irq before initializing corresponding data
structures. Fix this by moving request_irq call to a safer place.

Signed-off-by: Meelis Roos <mroos@linux.ee>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Meelis Roos authored and David S. Miller committed Mar 5, 2009
1 parent a883bf5 commit 8778694
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions drivers/net/tokenring/tmspci.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,6 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
goto err_out_trdev;
}

ret = request_irq(pdev->irq, tms380tr_interrupt, IRQF_SHARED,
dev->name, dev);
if (ret)
goto err_out_region;

dev->base_addr = pci_ioaddr;
dev->irq = pci_irq_line;
dev->dma = 0;
Expand All @@ -142,7 +137,7 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic
ret = tmsdev_init(dev, &pdev->dev);
if (ret) {
printk("%s: unable to get memory for dev->priv.\n", dev->name);
goto err_out_irq;
goto err_out_region;
}

tp = netdev_priv(dev);
Expand All @@ -157,22 +152,27 @@ static int __devinit tms_pci_attach(struct pci_dev *pdev, const struct pci_devic

tp->tmspriv = cardinfo;

ret = request_irq(pdev->irq, tms380tr_interrupt, IRQF_SHARED,
dev->name, dev);
if (ret)
goto err_out_tmsdev;

dev->open = tms380tr_open;
dev->stop = tms380tr_close;
pci_set_drvdata(pdev, dev);
SET_NETDEV_DEV(dev, &pdev->dev);

ret = register_netdev(dev);
if (ret)
goto err_out_tmsdev;
goto err_out_irq;

return 0;

err_out_irq:
free_irq(pdev->irq, dev);
err_out_tmsdev:
pci_set_drvdata(pdev, NULL);
tmsdev_term(dev);
err_out_irq:
free_irq(pdev->irq, dev);
err_out_region:
release_region(pci_ioaddr, TMS_PCI_IO_EXTENT);
err_out_trdev:
Expand Down

0 comments on commit 8778694

Please sign in to comment.