Skip to content

Commit

Permalink
staging: comedi: dyna_pci10xx: remove unused bars from the private data
Browse files Browse the repository at this point in the history
All of the pci device base address registers are saved in the private
data but only bar2 and bar3 are used by the driver. Remove the others.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
H Hartley Sweeten authored and Greg Kroah-Hartman committed Jul 19, 2012
1 parent 423e0e3 commit 8779060
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/staging/comedi/drivers/dyna_pci10xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ struct dyna_pci10xx_private {
struct mutex mutex;

/* device base address registers */
unsigned long BADR0, BADR1, BADR2, BADR3, BADR4, BADR5;
unsigned long BADR2, BADR3;
};

#define thisboard ((const struct boardtype *)dev->board_ptr)
Expand Down Expand Up @@ -288,13 +288,8 @@ static int dyna_pci10xx_attach(struct comedi_device *dev,

printk(KERN_INFO "comedi: dyna_pci10xx: device found!\n");

/* initialize device base address registers */
devpriv->BADR0 = pci_resource_start(pcidev, 0);
devpriv->BADR1 = pci_resource_start(pcidev, 1);
devpriv->BADR2 = pci_resource_start(pcidev, 2);
devpriv->BADR3 = pci_resource_start(pcidev, 3);
devpriv->BADR4 = pci_resource_start(pcidev, 4);
devpriv->BADR5 = pci_resource_start(pcidev, 5);

ret = comedi_alloc_subdevices(dev, 4);
if (ret)
Expand Down

0 comments on commit 8779060

Please sign in to comment.