Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 333079
b: refs/heads/master
c: a47df97
h: refs/heads/master
i:
  333077: 7d2286f
  333075: e59e3b2
  333071: 8de708c
v: v3
  • Loading branch information
Sachin Kamat authored and Bryan Wu committed Sep 12, 2012
1 parent 921b542 commit 878354f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 8fe4554f675c5822a0e12382e6843965ffd11c30
refs/heads/master: a47df97c9936cff6d31f03e12651ad897e0e374c
12 changes: 3 additions & 9 deletions trunk/drivers/leds/leds-lm3530.c
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ static int __devinit lm3530_probe(struct i2c_client *client,

i2c_set_clientdata(client, drvdata);

drvdata->regulator = regulator_get(&client->dev, "vin");
drvdata->regulator = devm_regulator_get(&client->dev, "vin");
if (IS_ERR(drvdata->regulator)) {
dev_err(&client->dev, "regulator get failed\n");
err = PTR_ERR(drvdata->regulator);
Expand All @@ -429,15 +429,13 @@ static int __devinit lm3530_probe(struct i2c_client *client,
if (err < 0) {
dev_err(&client->dev,
"Register Init failed: %d\n", err);
err = -ENODEV;
goto err_reg_init;
return -ENODEV;
}
}
err = led_classdev_register(&client->dev, &drvdata->led_dev);
if (err < 0) {
dev_err(&client->dev, "Register led class failed: %d\n", err);
err = -ENODEV;
goto err_class_register;
return -ENODEV;
}

err = device_create_file(drvdata->led_dev.dev, &dev_attr_mode);
Expand All @@ -451,9 +449,6 @@ static int __devinit lm3530_probe(struct i2c_client *client,

err_create_file:
led_classdev_unregister(&drvdata->led_dev);
err_class_register:
err_reg_init:
regulator_put(drvdata->regulator);
return err;
}

Expand All @@ -465,7 +460,6 @@ static int __devexit lm3530_remove(struct i2c_client *client)

if (drvdata->enable)
regulator_disable(drvdata->regulator);
regulator_put(drvdata->regulator);
led_classdev_unregister(&drvdata->led_dev);
return 0;
}
Expand Down

0 comments on commit 878354f

Please sign in to comment.