Skip to content

Commit

Permalink
drm/i915: Fix flushing regression from 9af90d1
Browse files Browse the repository at this point in the history
Whilst moving the code around in 9af90d1, I dropped the or'ing in of
new write domains which would zero out the write domain for a render
target if later reused as a source later in the batch. This meant that
we might drop a required flush before reading from the render target.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=31043
Reported-by: xunx.fang@intel.com
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Chris Wilson committed Oct 22, 2010
1 parent e27d853 commit 878a3c3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/i915_gem.c
Original file line number Diff line number Diff line change
Expand Up @@ -3349,7 +3349,7 @@ i915_gem_execbuffer_relocate(struct drm_i915_gem_object *obj,
}

target_obj->pending_read_domains |= reloc.read_domains;
target_obj->pending_write_domain = reloc.write_domain;
target_obj->pending_write_domain |= reloc.write_domain;

/* If the relocation already has the right value in it, no
* more work needs to be done.
Expand Down

0 comments on commit 878a3c3

Please sign in to comment.