Skip to content

Commit

Permalink
regulator: core: Replace checks of have_full_constraints with a function
Browse files Browse the repository at this point in the history
Simple code reorganisation so we can change the logic for deciding what
full constraints are more easily.

Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Mark Brown committed Nov 27, 2013
1 parent 6ce4eac commit 87b2841
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions drivers/regulator/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ static const char *rdev_get_name(struct regulator_dev *rdev)
return "";
}

static bool have_full_constraints(void)
{
return has_full_constraints;
}

/**
* of_get_regulator - get a regulator device node based on supply name
* @dev: Device pointer for the consumer (of regulator) device
Expand Down Expand Up @@ -1340,7 +1345,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
* Assume that a regulator is physically present and enabled
* even if it isn't hooked up and just provide a dummy.
*/
if (has_full_constraints && allow_dummy) {
if (have_full_constraints() && allow_dummy) {
pr_warn("%s supply %s not found, using dummy regulator\n",
devname, id);

Expand Down Expand Up @@ -3624,7 +3629,7 @@ int regulator_suspend_finish(void)
if (error)
ret = error;
} else {
if (!has_full_constraints)
if (!have_full_constraints())
goto unlock;
if (!ops->disable)
goto unlock;
Expand Down Expand Up @@ -3822,7 +3827,7 @@ static int __init regulator_init_complete(void)
if (!enabled)
goto unlock;

if (has_full_constraints) {
if (have_full_constraints()) {
/* We log since this may kill the system if it
* goes wrong. */
rdev_info(rdev, "disabling\n");
Expand Down

0 comments on commit 87b2841

Please sign in to comment.