Skip to content

Commit

Permalink
OMAP: DSS2: OMAPFB: swap front and back porches for both hsync and vsync
Browse files Browse the repository at this point in the history
Framebuffer's left and right margins are relative to the active pixel
area. Front and back porches are relative to the sync area.

Left margin was wrongly assigned to front porch (and right to back),
this patch fixes it.

Signed-off-by: tasskjapp@gmail.com
Reviewed-by: Russ.Dill@gmail.com
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
  • Loading branch information
Tasslehoff Kjappfot authored and Tomi Valkeinen committed Oct 22, 2010
1 parent 66be8f6 commit 87ba828
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/video/omap2/omapfb/omapfb-main.c
Original file line number Diff line number Diff line change
Expand Up @@ -714,10 +714,10 @@ int check_fb_var(struct fb_info *fbi, struct fb_var_screeninfo *var)
var->pixclock = timings.pixel_clock != 0 ?
KHZ2PICOS(timings.pixel_clock) :
0;
var->left_margin = timings.hfp;
var->right_margin = timings.hbp;
var->upper_margin = timings.vfp;
var->lower_margin = timings.vbp;
var->left_margin = timings.hbp;
var->right_margin = timings.hfp;
var->upper_margin = timings.vbp;
var->lower_margin = timings.vfp;
var->hsync_len = timings.hsw;
var->vsync_len = timings.vsw;
} else {
Expand Down Expand Up @@ -2059,10 +2059,10 @@ static int omapfb_mode_to_timings(const char *mode_str,

if (r != 0) {
timings->pixel_clock = PICOS2KHZ(var.pixclock);
timings->hfp = var.left_margin;
timings->hbp = var.right_margin;
timings->vfp = var.upper_margin;
timings->vbp = var.lower_margin;
timings->hbp = var.left_margin;
timings->hfp = var.right_margin;
timings->vbp = var.upper_margin;
timings->vfp = var.lower_margin;
timings->hsw = var.hsync_len;
timings->vsw = var.vsync_len;
timings->x_res = var.xres;
Expand Down

0 comments on commit 87ba828

Please sign in to comment.