Skip to content

Commit

Permalink
igb: reenable CRC stripping in hardware
Browse files Browse the repository at this point in the history
We can remove a clunky workaround for not having the hardware
strip the CRC. 82575 silicon as well as the older PCI Express
e1000e hardware all work OK in this respect.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Auke Kok authored and Jeff Garzik committed Jul 11, 2008
1 parent fe4506b commit 87cb7e8
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/net/igb/igb_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -1664,10 +1664,12 @@ static void igb_setup_rctl(struct igb_adapter *adapter)
E1000_RCTL_LBM_NO | E1000_RCTL_RDMTS_HALF |
(adapter->hw.mac.mc_filter_type << E1000_RCTL_MO_SHIFT);

/* disable the stripping of CRC because it breaks
* BMC firmware connected over SMBUS
rctl |= E1000_RCTL_SECRC;
/*
* enable stripping of CRC. It's unlikely this will break BMC
* redirection as it did with e1000. Newer features require
* that the HW strips the CRC.
*/
rctl |= E1000_RCTL_SECRC;

rctl &= ~E1000_RCTL_SBP;

Expand Down Expand Up @@ -3743,7 +3745,6 @@ static bool igb_clean_rx_irq_adv(struct igb_ring *rx_ring,
}
}
send_up:
pskb_trim(skb, skb->len - 4);
i++;
if (i == rx_ring->count)
i = 0;
Expand Down

0 comments on commit 87cb7e8

Please sign in to comment.