Skip to content

Commit

Permalink
[PATCH] i2o: Do not disable pci device when it's in use
Browse files Browse the repository at this point in the history
When dpt_i2o is loaded first, i2o being loaded would cause it to call
pci_device_disable, thus breaking dpt_i2o's use of the device.  Based on
similar usage of pci_disable_device in other drivers.

Signed-off-by: Ben Collins <bcollins@ubuntu.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Ben Collins authored and Linus Torvalds committed Dec 18, 2005
1 parent 48ea753 commit 87d47d0
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/message/i2o/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ static int __devinit i2o_pci_probe(struct pci_dev *pdev,
struct i2o_controller *c;
int rc;
struct pci_dev *i960 = NULL;
int pci_dev_busy = 0;

printk(KERN_INFO "i2o: Checking for PCI I2O controllers...\n");

Expand Down Expand Up @@ -395,6 +396,8 @@ static int __devinit i2o_pci_probe(struct pci_dev *pdev,
if ((rc = i2o_pci_alloc(c))) {
printk(KERN_ERR "%s: DMA / IO allocation for I2O controller "
" failed\n", c->name);
if (rc == -ENODEV)
pci_dev_busy = 1;
goto free_controller;
}

Expand Down Expand Up @@ -425,7 +428,8 @@ static int __devinit i2o_pci_probe(struct pci_dev *pdev,
i2o_iop_free(c);

disable:
pci_disable_device(pdev);
if (!pci_dev_busy)
pci_disable_device(pdev);

return rc;
}
Expand Down

0 comments on commit 87d47d0

Please sign in to comment.