Skip to content

Commit

Permalink
[POWERPC] Quiet hvc_console console output on failed opens
Browse files Browse the repository at this point in the history
No other tty driver will print on the console when the open of it fails.

On systems that happen to be configured for both ttyS0 and hvc0 console,
this will keep flooding the console output.  This is most likely to
happen with systems booted between with and without hypervisor from the
same filesystem.

Let's just remove it. When it's really needed (i.e. when the open fails
and someone is trying to debug it), noone will see the output anyway. And
init will report the opens failing in due time through the syslog.

Signed-off-by: Olof Johansson <olof@lixom.net>
Acked-by: Ryan S. Arnold <rsa@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Olof Johansson authored and Paul Mackerras committed Sep 13, 2006
1 parent 06e6d29 commit 87fd772
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/char/hvc_console.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,8 @@ static int hvc_open(struct tty_struct *tty, struct file * filp)
struct kobject *kobjp;

/* Auto increments kobject reference if found. */
if (!(hp = hvc_get_by_index(tty->index))) {
printk(KERN_WARNING "hvc_console: tty open failed, no vty associated with tty.\n");
if (!(hp = hvc_get_by_index(tty->index)))
return -ENODEV;
}

spin_lock_irqsave(&hp->lock, flags);
/* Check and then increment for fast path open. */
Expand Down

0 comments on commit 87fd772

Please sign in to comment.