Skip to content

Commit

Permalink
[NETFILTER]: nf_conntrack_netbios_ns: fix uninitialized member in exp…
Browse files Browse the repository at this point in the history
…ectation

->helper is uninitialized in the expectation registered by the netbios_ns
helper and it later copied to the expected connection, which causes invalid
memory dereferences when trying to call the helper.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Patrick McHardy authored and David S. Miller committed Jan 9, 2007
1 parent c1d2a19 commit 88044c8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions net/netfilter/nf_conntrack_netbios_ns.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ static int help(struct sk_buff **pskb, unsigned int protoff,

exp->expectfn = NULL;
exp->flags = NF_CT_EXPECT_PERMANENT;
exp->helper = NULL;

nf_conntrack_expect_related(exp);
nf_conntrack_expect_put(exp);
Expand Down

0 comments on commit 88044c8

Please sign in to comment.