Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 305237
b: refs/heads/master
c: 9ea6404
h: refs/heads/master
i:
  305235: 19b0729
v: v3
  • Loading branch information
Paul Mundt committed May 10, 2012
1 parent 26f550f commit 8814fa2
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 25 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f9e2eae6c66437a414988b44e1d2b8c025134883
refs/heads/master: 9ea6404691a520f734b819cbbd4757b0ea5f99c6
50 changes: 26 additions & 24 deletions trunk/drivers/watchdog/shwdt.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
#include <linux/mm.h>
#include <linux/slab.h>
#include <linux/io.h>
#include <linux/clk.h>
#include <asm/watchdog.h>

#define DRV_NAME "sh-wdt"
Expand Down Expand Up @@ -74,6 +75,7 @@ static unsigned long next_heartbeat;
struct sh_wdt {
void __iomem *base;
struct device *dev;
struct clk *clk;
spinlock_t lock;

struct timer_list timer;
Expand Down Expand Up @@ -225,27 +227,32 @@ static int __devinit sh_wdt_probe(struct platform_device *pdev)
if (unlikely(!res))
return -EINVAL;

if (!devm_request_mem_region(&pdev->dev, res->start,
resource_size(res), DRV_NAME))
return -EBUSY;

wdt = devm_kzalloc(&pdev->dev, sizeof(struct sh_wdt), GFP_KERNEL);
if (unlikely(!wdt)) {
rc = -ENOMEM;
goto out_release;
}
if (unlikely(!wdt))
return -ENOMEM;

wdt->dev = &pdev->dev;

watchdog_set_nowayout(&sh_wdt_dev, nowayout);
watchdog_set_drvdata(&sh_wdt_dev, wdt);
wdt->clk = clk_get(&pdev->dev, NULL);
if (IS_ERR(wdt->clk)) {
/*
* Clock framework support is optional, continue on
* anyways if we don't find a matching clock.
*/
wdt->clk = NULL;
}

wdt->base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
clk_enable(wdt->clk);

wdt->base = devm_request_and_ioremap(wdt->dev, res);
if (unlikely(!wdt->base)) {
rc = -ENXIO;
goto out_err;
rc = -EADDRNOTAVAIL;
goto out_disable;
}

watchdog_set_nowayout(&sh_wdt_dev, nowayout);
watchdog_set_drvdata(&sh_wdt_dev, wdt);

spin_lock_init(&wdt->lock);

rc = sh_wdt_set_heartbeat(&sh_wdt_dev, heartbeat);
Expand All @@ -264,7 +271,7 @@ static int __devinit sh_wdt_probe(struct platform_device *pdev)
rc = watchdog_register_device(&sh_wdt_dev);
if (unlikely(rc)) {
dev_err(&pdev->dev, "Can't register watchdog (err=%d)\n", rc);
goto out_unmap;
goto out_disable;
}

init_timer(&wdt->timer);
Expand All @@ -278,28 +285,23 @@ static int __devinit sh_wdt_probe(struct platform_device *pdev)

return 0;

out_unmap:
devm_iounmap(&pdev->dev, wdt->base);
out_err:
devm_kfree(&pdev->dev, wdt);
out_release:
devm_release_mem_region(&pdev->dev, res->start, resource_size(res));
out_disable:
clk_disable(wdt->clk);
clk_put(wdt->clk);

return rc;
}

static int __devexit sh_wdt_remove(struct platform_device *pdev)
{
struct sh_wdt *wdt = platform_get_drvdata(pdev);
struct resource *res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

platform_set_drvdata(pdev, NULL);

watchdog_unregister_device(&sh_wdt_dev);

devm_release_mem_region(&pdev->dev, res->start, resource_size(res));
devm_iounmap(&pdev->dev, wdt->base);
devm_kfree(&pdev->dev, wdt);
clk_disable(wdt->clk);
clk_put(wdt->clk);

return 0;
}
Expand Down

0 comments on commit 8814fa2

Please sign in to comment.