Skip to content

Commit

Permalink
um: fix ptrace build error
Browse files Browse the repository at this point in the history
Both commits 0a3d763 ("ptrace: cleanup arch_ptrace() on um") and
9b05a69 ("ptrace: change signature of arch_ptrace()") broke the um
build.  This patch fixes the issues.

0a3d763 introduced the undeclared variable "datavp".  The patch seems
completely untested.  :-(

9b05a69 changed arch_ptrace()'s signature but did not update
um/include/asm/ptrace-generic.h.

Signed-off-by: Richard Weinberger <richard@nod.at>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Jeff Dike <jdike@addtoit.com>
Tested-by: Will Newton <will.newton@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Richard Weinberger authored and Linus Torvalds committed Nov 12, 2010
1 parent f6614b7 commit 8818b67
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions arch/um/include/asm/ptrace-generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ struct pt_regs {

struct task_struct;

extern long subarch_ptrace(struct task_struct *child, long request, long addr,
long data);
extern long subarch_ptrace(struct task_struct *child, long request,
unsigned long addr, unsigned long data);
extern unsigned long getreg(struct task_struct *child, int regno);
extern int putreg(struct task_struct *child, int regno, unsigned long value);
extern int get_fpregs(struct user_i387_struct __user *buf,
Expand Down
2 changes: 1 addition & 1 deletion arch/um/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ long arch_ptrace(struct task_struct *child, long request,
break;

case PTRACE_SET_THREAD_AREA:
ret = ptrace_set_thread_area(child, addr, datavp);
ret = ptrace_set_thread_area(child, addr, vp);
break;

case PTRACE_FAULTINFO: {
Expand Down

0 comments on commit 8818b67

Please sign in to comment.