Skip to content

Commit

Permalink
[SCSI] pmcraid: Fix ppc64 driver build for using cpu_to_le32 on U8 da…
Browse files Browse the repository at this point in the history
…ta type

Fix a reported ppc64 driver build issue. Removed cpu_to_le32 conversion
usage for flags in struct pmcraid_ioadl_desc. This was breaking the driver build in ppc64.

drivers/scsi/pmcraid.c: In function 'pmcraid_request_sense':
drivers/scsi/pmcraid.c:2254: warning: large integer implicitly truncated
to unsigned type

Signed-off-by: Anil Ravindranath<anil_ravindranath@pmc-sierra.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
Anil Ravindranath authored and James Bottomley committed Nov 6, 2009
1 parent 3feeb89 commit 8819796
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/scsi/pmcraid.c
Original file line number Diff line number Diff line change
Expand Up @@ -1071,7 +1071,7 @@ static struct pmcraid_cmd *pmcraid_init_hcam

ioarcb->data_transfer_length = cpu_to_le32(rcb_size);

ioadl[0].flags |= cpu_to_le32(IOADL_FLAGS_READ_LAST);
ioadl[0].flags |= IOADL_FLAGS_READ_LAST;
ioadl[0].data_len = cpu_to_le32(rcb_size);
ioadl[0].address = cpu_to_le32(dma);

Expand Down Expand Up @@ -2251,7 +2251,7 @@ static void pmcraid_request_sense(struct pmcraid_cmd *cmd)

ioadl->address = cpu_to_le64(cmd->sense_buffer_dma);
ioadl->data_len = cpu_to_le32(SCSI_SENSE_BUFFERSIZE);
ioadl->flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);
ioadl->flags = IOADL_FLAGS_LAST_DESC;

/* request sense might be called as part of error response processing
* which runs in tasklets context. It is possible that mid-layer might
Expand Down Expand Up @@ -3017,7 +3017,7 @@ static int pmcraid_build_ioadl(
ioadl[i].flags = 0;
}
/* setup last descriptor */
ioadl[i - 1].flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);
ioadl[i - 1].flags = IOADL_FLAGS_LAST_DESC;

return 0;
}
Expand Down Expand Up @@ -3387,7 +3387,7 @@ static int pmcraid_build_passthrough_ioadls(
}

/* setup the last descriptor */
ioadl[i - 1].flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);
ioadl[i - 1].flags = IOADL_FLAGS_LAST_DESC;

return 0;
}
Expand Down Expand Up @@ -5314,7 +5314,7 @@ static void pmcraid_querycfg(struct pmcraid_cmd *cmd)
cpu_to_le32(sizeof(struct pmcraid_config_table));

ioadl = &(ioarcb->add_data.u.ioadl[0]);
ioadl->flags = cpu_to_le32(IOADL_FLAGS_LAST_DESC);
ioadl->flags = IOADL_FLAGS_LAST_DESC;
ioadl->address = cpu_to_le64(pinstance->cfg_table_bus_addr);
ioadl->data_len = cpu_to_le32(sizeof(struct pmcraid_config_table));

Expand Down

0 comments on commit 8819796

Please sign in to comment.