Skip to content

Commit

Permalink
kset: convert /sys/devices to use kset_create
Browse files Browse the repository at this point in the history
Dynamically create the kset instead of declaring it statically.  We also
rename devices_subsys to devices_kset to catch all users of the
variable.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Greg Kroah-Hartman committed Jan 25, 2008
1 parent b0d78e5 commit 881c6cf
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion drivers/base/base.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ extern char *make_class_name(const char *name, struct kobject *kobj);

extern int devres_release_all(struct device *dev);

extern struct kset devices_subsys;
extern struct kset *devices_kset;
16 changes: 8 additions & 8 deletions drivers/base/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,11 +401,8 @@ static ssize_t show_dev(struct device *dev, struct device_attribute *attr,
static struct device_attribute devt_attr =
__ATTR(dev, S_IRUGO, show_dev, NULL);

/*
* devices_subsys - structure to be registered with kobject core.
*/

decl_subsys(devices, &device_uevent_ops);
/* kset to create /sys/devices/ */
struct kset *devices_kset;


/**
Expand Down Expand Up @@ -525,7 +522,7 @@ static void klist_children_put(struct klist_node *n)

void device_initialize(struct device *dev)
{
dev->kobj.kset = &devices_subsys;
dev->kobj.kset = devices_kset;
dev->kobj.ktype = &device_ktype;
kobject_init(&dev->kobj);
klist_init(&dev->klist_children, klist_children_get,
Expand Down Expand Up @@ -563,7 +560,7 @@ static struct kobject *virtual_device_parent(struct device *dev)

if (!virtual_dir)
virtual_dir = kobject_create_and_add("virtual",
&devices_subsys.kobj);
&devices_kset->kobj);

return virtual_dir;
}
Expand Down Expand Up @@ -1097,7 +1094,10 @@ struct device * device_find_child(struct device *parent, void *data,

int __init devices_init(void)
{
return subsystem_register(&devices_subsys);
devices_kset = kset_create_and_add("devices", &device_uevent_ops, NULL);
if (!devices_kset)
return -ENOMEM;
return 0;
}

EXPORT_SYMBOL_GPL(device_for_each_child);
Expand Down
2 changes: 1 addition & 1 deletion drivers/base/power/shutdown.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void device_shutdown(void)
{
struct device * dev, *devn;

list_for_each_entry_safe_reverse(dev, devn, &devices_subsys.list,
list_for_each_entry_safe_reverse(dev, devn, &devices_kset->list,
kobj.entry) {
if (dev->bus && dev->bus->shutdown) {
dev_dbg(dev, "shutdown\n");
Expand Down
4 changes: 1 addition & 3 deletions drivers/base/sys.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@

#include "base.h"

extern struct kset devices_subsys;

#define to_sysdev(k) container_of(k, struct sys_device, kobj)
#define to_sysdev_attr(a) container_of(a, struct sysdev_attribute, attr)

Expand Down Expand Up @@ -459,7 +457,7 @@ int sysdev_resume(void)

int __init system_bus_init(void)
{
system_subsys.kobj.parent = &devices_subsys.kobj;
system_subsys.kobj.parent = &devices_kset->kobj;
return subsystem_register(&system_subsys);
}

Expand Down

0 comments on commit 881c6cf

Please sign in to comment.