Skip to content

Commit

Permalink
isdn/hysdn: Convert to kstrtoul_from_user
Browse files Browse the repository at this point in the history
This patch replaces the code for getting an number from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Peter Hüwe authored and David S. Miller committed Apr 15, 2012
1 parent cf22f9a commit 8831a3f
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions drivers/isdn/hysdn/hysdn_proclog.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,9 @@ static ssize_t
hysdn_log_write(struct file *file, const char __user *buf, size_t count, loff_t *off)
{
int rc;
unsigned char valbuf[128];
hysdn_card *card = file->private_data;

if (count > (sizeof(valbuf) - 1))
count = sizeof(valbuf) - 1; /* limit length */
if (copy_from_user(valbuf, buf, count))
return (-EFAULT); /* copy failed */

valbuf[count] = 0; /* terminating 0 */

rc = kstrtoul(valbuf, 0, &card->debug_flags);
rc = kstrtoul_from_user(buf, count, 0, &card->debug_flags);
if (rc < 0)
return rc;
hysdn_addlog(card, "debug set to 0x%lx", card->debug_flags);
Expand Down

0 comments on commit 8831a3f

Please sign in to comment.