Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 67862
b: refs/heads/master
c: ee7d1f3
h: refs/heads/master
v: v3
  • Loading branch information
Alan Stern authored and Greg Kroah-Hartman committed Oct 12, 2007
1 parent 6c40ea4 commit 88437df
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 10 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: dfd1e53777afe1050e3a0a3f0dd063a64242b818
refs/heads/master: ee7d1f3f0c32d8abe9627aa73dc62ee5bf2daf7f
1 change: 0 additions & 1 deletion trunk/drivers/usb/host/uhci-hcd.h
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ struct uhci_qh {
short phase; /* Between 0 and period-1 */
short load; /* Periodic time requirement, in us */
unsigned int iso_frame; /* Frame # for iso_packet_desc */
int iso_status; /* Status for Isochronous URBs */

int state; /* QH_STATE_xxx; see above */
int type; /* Queue type (control, bulk, etc) */
Expand Down
11 changes: 3 additions & 8 deletions trunk/drivers/usb/host/uhci-q.c
Original file line number Diff line number Diff line change
Expand Up @@ -1324,7 +1324,6 @@ static int uhci_submit_isochronous(struct uhci_hcd *uhci, struct urb *urb,
if (list_empty(&qh->queue)) {
qh->iso_packet_desc = &urb->iso_frame_desc[0];
qh->iso_frame = urb->start_frame;
qh->iso_status = 0;
}

qh->skel = SKEL_ISO;
Expand Down Expand Up @@ -1361,18 +1360,15 @@ static int uhci_result_isochronous(struct uhci_hcd *uhci, struct urb *urb)
qh->iso_packet_desc->actual_length = actlength;
qh->iso_packet_desc->status = status;
}

if (status) {
if (status)
urb->error_count++;
qh->iso_status = status;
}

uhci_remove_td_from_urbp(td);
uhci_free_td(uhci, td);
qh->iso_frame += qh->period;
++qh->iso_packet_desc;
}
return qh->iso_status;
return 0;
}

static int uhci_urb_enqueue(struct usb_hcd *hcd,
Expand Down Expand Up @@ -1517,7 +1513,6 @@ __acquires(uhci->lock)

qh->iso_packet_desc = &nurb->iso_frame_desc[0];
qh->iso_frame = nurb->start_frame;
qh->iso_status = 0;
}

/* Take the URB off the QH's queue. If the queue is now empty,
Expand Down Expand Up @@ -1586,7 +1581,7 @@ static void uhci_scan_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
}

uhci_giveback_urb(uhci, qh, urb);
if (status < 0 && qh->type != USB_ENDPOINT_XFER_ISOC)
if (status < 0)
break;
}

Expand Down

0 comments on commit 88437df

Please sign in to comment.