Skip to content

Commit

Permalink
nfsd: reorder printk in do_probe_callback to avoid use-after-free
Browse files Browse the repository at this point in the history
We're currently dereferencing the client after we drop our reference
count to it.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
J. Bruce Fields committed May 18, 2008
1 parent b8291ad commit 88dd0be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfsd/nfs4callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -419,9 +419,9 @@ static int do_probe_callback(void *data)
out_release_client:
rpc_shutdown_client(client);
out_err:
put_nfs4_client(clp);
dprintk("NFSD: warning: no callback path to client %.*s\n",
(int)clp->cl_name.len, clp->cl_name.data);
put_nfs4_client(clp);
return status;
}

Expand Down

0 comments on commit 88dd0be

Please sign in to comment.