Skip to content

Commit

Permalink
[ARM] pxa: Fix PXA27x suspend type validation, remove pxa_pm_prepare()
Browse files Browse the repository at this point in the history
pxa_pm_prepare() tried to validate the suspend method type.  As
noted in previous commits:
	eb9289e
	9c372d0
	e8c9c50

the checking of the suspend type in the 'prepare' method is the
wrong place to do this; use the 'valid' method instead.  This
means that pxa_pm_prepare() can be entirely removed.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Russell King committed Jul 12, 2007
1 parent e176bb0 commit 88dfe98
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 27 deletions.
1 change: 0 additions & 1 deletion arch/arm/common/sharpsl_pm.c
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,6 @@ static void sharpsl_apm_get_power_status(struct apm_power_info *info)
}

static struct pm_ops sharpsl_pm_ops = {
.prepare = pxa_pm_prepare,
.enter = corgi_pxa_pm_enter,
.valid = pm_valid_only_mem,
};
Expand Down
13 changes: 0 additions & 13 deletions arch/arm/mach-pxa/pxa25x.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,18 +106,6 @@ EXPORT_SYMBOL(get_lcdclk_frequency_10khz);

#ifdef CONFIG_PM

int pxa_pm_prepare(suspend_state_t state)
{
switch (state) {
case PM_SUSPEND_MEM:
break;
default:
return -EINVAL;
}

return 0;
}

void pxa_cpu_pm_enter(suspend_state_t state)
{
extern void pxa_cpu_suspend(unsigned int);
Expand All @@ -135,7 +123,6 @@ void pxa_cpu_pm_enter(suspend_state_t state)
}

static struct pm_ops pxa25x_pm_ops = {
.prepare = pxa_pm_prepare,
.enter = pxa_pm_enter,
.valid = pm_valid_only_mem,
};
Expand Down
19 changes: 6 additions & 13 deletions arch/arm/mach-pxa/pxa27x.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,17 +123,6 @@ EXPORT_SYMBOL(get_lcdclk_frequency_10khz);

#ifdef CONFIG_PM

int pxa_pm_prepare(suspend_state_t state)
{
switch (state) {
case PM_SUSPEND_MEM:
case PM_SUSPEND_STANDBY:
return 0;
default:
return -EINVAL;
}
}

void pxa_cpu_pm_enter(suspend_state_t state)
{
extern void pxa_cpu_standby(void);
Expand Down Expand Up @@ -163,10 +152,14 @@ void pxa_cpu_pm_enter(suspend_state_t state)
}
}

static int pxa27x_pm_valid(suspend_state_t state)
{
return state == PM_SUSPEND_MEM || state == PM_SUSPEND_STANDBY;
}

static struct pm_ops pxa27x_pm_ops = {
.prepare = pxa_pm_prepare,
.enter = pxa_pm_enter,
.valid = pm_valid_only_mem,
.valid = pxa27x_pm_valid,
};
#endif

Expand Down

0 comments on commit 88dfe98

Please sign in to comment.