Skip to content

Commit

Permalink
i7core_edac: it is safe to i7core_unregister_mci() when mci=NULL
Browse files Browse the repository at this point in the history
i7core_unregister_mci() checks internally when mci=NULL. There's no
need to test it outside.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mauro Carvalho Chehab committed Oct 24, 2010
1 parent 6d37d24 commit 88ef5ea
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions drivers/edac/i7core_edac.c
Original file line number Diff line number Diff line change
Expand Up @@ -2091,10 +2091,9 @@ static int __devinit i7core_probe(struct pci_dev *pdev,
return 0;

fail1:
list_for_each_entry(i7core_dev, &i7core_edac_list, list) {
if (i7core_dev->mci)
i7core_unregister_mci(i7core_dev);
}
list_for_each_entry(i7core_dev, &i7core_edac_list, list)
i7core_unregister_mci(i7core_dev);

i7core_put_all_devices();
fail0:
mutex_unlock(&i7core_edac_lock);
Expand Down Expand Up @@ -2126,10 +2125,8 @@ static void __devexit i7core_remove(struct pci_dev *pdev)
return;
}

list_for_each_entry(i7core_dev, &i7core_edac_list, list) {
if (i7core_dev->mci)
i7core_unregister_mci(i7core_dev);
}
list_for_each_entry(i7core_dev, &i7core_edac_list, list)
i7core_unregister_mci(i7core_dev);

/* Release PCI resources */
i7core_put_all_devices();
Expand Down

0 comments on commit 88ef5ea

Please sign in to comment.