Skip to content

Commit

Permalink
[PATCH] uml: fix mknod
Browse files Browse the repository at this point in the history
Fix UML hostfs mknod(): userspace has differernt dev_t size and encoding
than kernel, so extract major/minor and reencode using glibc makedev()
macro.

Signed-off-by: Johannes Stezenbach <js@linuxtv.org>
Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Johannes Stezenbach authored and Linus Torvalds committed Jan 30, 2007
1 parent 7a238fc commit 88f6cd0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion fs/hostfs/hostfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ extern int make_symlink(const char *from, const char *to);
extern int unlink_file(const char *file);
extern int do_mkdir(const char *file, int mode);
extern int do_rmdir(const char *file);
extern int do_mknod(const char *file, int mode, int dev);
extern int do_mknod(const char *file, int mode, unsigned int major, unsigned int minor);
extern int link_file(const char *from, const char *to);
extern int do_readlink(char *file, char *buf, int size);
extern int rename_file(char *from, char *to);
Expand Down
2 changes: 1 addition & 1 deletion fs/hostfs/hostfs_kern.c
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ int hostfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev)
goto out_put;

init_special_inode(inode, mode, dev);
err = do_mknod(name, mode, dev);
err = do_mknod(name, mode, MAJOR(dev), MINOR(dev));
if(err)
goto out_free;

Expand Down
4 changes: 2 additions & 2 deletions fs/hostfs/hostfs_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,11 @@ int do_rmdir(const char *file)
return(0);
}

int do_mknod(const char *file, int mode, int dev)
int do_mknod(const char *file, int mode, unsigned int major, unsigned int minor)
{
int err;

err = mknod(file, mode, dev);
err = mknod(file, mode, makedev(major, minor));
if(err) return(-errno);
return(0);
}
Expand Down

0 comments on commit 88f6cd0

Please sign in to comment.