Skip to content

Commit

Permalink
dma: mv_xor: Remove unneeded mv_xor_clean_completed_slots() call
Browse files Browse the repository at this point in the history
In mv_xor_status(), we are currently calling mv_xor_clean_completed_slots()
when the transaction is complete (the cookie status is DMA_COMPLETE).
However, a completed status means that mv_xor_slot_cleanup() was called,
which cleans the completed slots.

In other words, there's nothing to cleanup for a completed transaction in
mv_xor_status(). Remove the unneeded call to mv_xor_clean_completed_slots().

Reported-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
Ezequiel Garcia authored and Dan Williams committed Apr 10, 2014
1 parent 368da99 commit 890766d
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions drivers/dma/mv_xor.c
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,8 @@ static enum dma_status mv_xor_status(struct dma_chan *chan,
enum dma_status ret;

ret = dma_cookie_status(chan, cookie, txstate);
if (ret == DMA_COMPLETE) {
mv_xor_clean_completed_slots(mv_chan);
if (ret == DMA_COMPLETE)
return ret;
}
mv_xor_slot_cleanup(mv_chan);

return dma_cookie_status(chan, cookie, txstate);
Expand Down

0 comments on commit 890766d

Please sign in to comment.