Skip to content

Commit

Permalink
[PATCH] md: remove arbitrary limit on chunk size
Browse files Browse the repository at this point in the history
The largest chunk size the code can support without substantial surgery is
2^30 bytes, so make that the limit instead of an arbitrary 4Meg.  Some day,
the 'chunksize' should change to a sector-shift instead of a byte-count.  Then
no limit would be needed.

Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
NeilBrown authored and Linus Torvalds committed Jun 26, 2006
1 parent c70810b commit 8932c2e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/md/raid10.c
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,7 @@ static int run(mddev_t *mddev)
* maybe...
*/
{
int stripe = conf->raid_disks * mddev->chunk_size / PAGE_SIZE;
int stripe = conf->raid_disks * (mddev->chunk_size / PAGE_SIZE);
stripe /= conf->near_copies;
if (mddev->queue->backing_dev_info.ra_pages < 2* stripe)
mddev->queue->backing_dev_info.ra_pages = 2* stripe;
Expand Down
4 changes: 2 additions & 2 deletions drivers/md/raid5.c
Original file line number Diff line number Diff line change
Expand Up @@ -2382,8 +2382,8 @@ static int run(mddev_t *mddev)
* 2 * (n-1) * chunksize where 'n' is the number of raid devices
*/
{
int stripe = (mddev->raid_disks-1) * mddev->chunk_size
/ PAGE_SIZE;
int stripe = (mddev->raid_disks-1) *
(mddev->chunk_size / PAGE_SIZE);
if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe)
mddev->queue->backing_dev_info.ra_pages = 2 * stripe;
}
Expand Down
4 changes: 2 additions & 2 deletions drivers/md/raid6main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2135,8 +2135,8 @@ static int run(mddev_t *mddev)
* 2 * (n-2) * chunksize where 'n' is the number of raid devices
*/
{
int stripe = (mddev->raid_disks-2) * mddev->chunk_size
/ PAGE_SIZE;
int stripe = (mddev->raid_disks-2) *
(mddev->chunk_size / PAGE_SIZE);
if (mddev->queue->backing_dev_info.ra_pages < 2 * stripe)
mddev->queue->backing_dev_info.ra_pages = 2 * stripe;
}
Expand Down
3 changes: 2 additions & 1 deletion include/linux/raid/md_k.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ typedef struct mdk_rdev_s mdk_rdev_t;
* options passed in raidrun:
*/

#define MAX_CHUNK_SIZE (4096*1024)
/* Currently this must fix in an 'int' */
#define MAX_CHUNK_SIZE (1<<30)

/*
* MD's 'extended' device
Expand Down

0 comments on commit 8932c2e

Please sign in to comment.