Skip to content

Commit

Permalink
drm/i915/dp: cache eDP DPCD data
Browse files Browse the repository at this point in the history
Cache the first 4 bytes of DPCD data in the eDP case.  It's unlikely to
change and can save us some trouble at link training time.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
  • Loading branch information
Jesse Barnes authored and Chris Wilson committed Oct 8, 2010
1 parent 8088699 commit 8966738
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/i915/i915_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,7 @@ typedef struct drm_i915_private {
int bpp;
struct edp_power_seq pps;
} edp;
bool no_aux_handshake;

struct notifier_block lid_notifier;

Expand Down
20 changes: 20 additions & 0 deletions drivers/gpu/drm/i915/intel_dp.c
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,26 @@ intel_dp_init(struct drm_device *dev, int output_reg)

intel_dp_i2c_init(intel_dp, intel_connector, name);

/* Cache some DPCD data in the eDP case */
if (is_edp(intel_dp)) {
int ret;
bool was_on;

was_on = ironlake_edp_panel_on(intel_dp);
ret = intel_dp_aux_native_read(intel_dp, DP_DPCD_REV,
intel_dp->dpcd,
sizeof(intel_dp->dpcd));
if (ret == sizeof(intel_dp->dpcd)) {
if (intel_dp->dpcd[0] >= 0x11)
dev_priv->no_aux_handshake = intel_dp->dpcd[3] &
DP_NO_AUX_HANDSHAKE_LINK_TRAINING;
} else {
DRM_ERROR("failed to retrieve link info\n");
}
if (!was_on)
ironlake_edp_panel_off(dev);
}

intel_encoder->hot_plug = intel_dp_hot_plug;

if (is_edp(intel_dp)) {
Expand Down

0 comments on commit 8966738

Please sign in to comment.