Skip to content

Commit

Permalink
drm: rcar-du: Convert rcar_du_encoders_init_one() return value to 0/<0
Browse files Browse the repository at this point in the history
The function returns 1 on success, and either 0 or a negative error code
on failure. As the 0 and negative values don't need to be differentiated
by the caller, convert it to the usual scheme of returning 0 on success
and a negative error code on failure.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
  • Loading branch information
Laurent Pinchart committed Jun 16, 2015
1 parent 64549cd commit 898a2f3
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/gpu/drm/rcar-du/rcar_du_kms.c
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
if (!entity) {
dev_dbg(rcdu->dev, "unconnected endpoint %s, skipping\n",
ep->local_node->full_name);
return 0;
return -ENODEV;
}

entity_ep_node = of_parse_phandle(ep->local_node, "remote-endpoint", 0);
Expand All @@ -596,7 +596,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name);
of_node_put(entity_ep_node);
of_node_put(encoder);
return 0;
return -ENODEV;
}

break;
Expand Down Expand Up @@ -625,7 +625,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
encoder->full_name);
of_node_put(encoder);
of_node_put(connector);
return 0;
return -EINVAL;
}
} else {
/*
Expand All @@ -644,7 +644,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
"failed to initialize encoder %s (%d), skipping\n",
encoder->full_name, ret);

return ret < 0 ? ret : 1;
return ret;
}

static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
Expand Down Expand Up @@ -696,7 +696,7 @@ static int rcar_du_encoders_init(struct rcar_du_device *rcdu)
continue;
}

num_encoders += ret;
num_encoders++;
}

return num_encoders;
Expand Down

0 comments on commit 898a2f3

Please sign in to comment.