Skip to content

Commit

Permalink
staging:wlan-ng: cleanup hfa384x_ctlxout_callback
Browse files Browse the repository at this point in the history
goto done is not required and actually having goto done does
jumps the program to end of the function and calls return.
instead call return directly

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Devendra Naga authored and Greg Kroah-Hartman committed Sep 10, 2012
1 parent 3f51425 commit 89e6302
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions drivers/staging/wlan-ng/hfa384x_usb.c
Original file line number Diff line number Diff line change
Expand Up @@ -3790,7 +3790,7 @@ static void hfa384x_ctlxout_callback(struct urb *urb)
#endif
if ((urb->status == -ESHUTDOWN) ||
(urb->status == -ENODEV) || (hw == NULL))
goto done;
return;

retry:
spin_lock_irqsave(&hw->ctlxq.lock, flags);
Expand All @@ -3803,7 +3803,7 @@ static void hfa384x_ctlxout_callback(struct urb *urb)
*/
if (list_empty(&hw->ctlxq.active)) {
spin_unlock_irqrestore(&hw->ctlxq.lock, flags);
goto done;
return;
}

/*
Expand Down Expand Up @@ -3886,9 +3886,6 @@ static void hfa384x_ctlxout_callback(struct urb *urb)

if (run_queue)
hfa384x_usbctlxq_run(hw);

done:
;
}

/*----------------------------------------------------------------
Expand Down

0 comments on commit 89e6302

Please sign in to comment.