Skip to content

Commit

Permalink
[PATCH] Revert ABI-breaking change in /proc
Browse files Browse the repository at this point in the history
Some user tools parse /proc/scsi/scsi, so we can't yet change the names.
Change the existing ones back to their old names, and add an admonition
to not make the same mistake that I did.

Andrew Morton reports that this was breaking YDL 4.1 userspace.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Matthew Wilcox authored and Linus Torvalds committed Sep 25, 2006
1 parent 508df25 commit 8a1cdc9
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions drivers/scsi/scsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,22 +96,26 @@ unsigned int scsi_logging_level;
EXPORT_SYMBOL(scsi_logging_level);
#endif

/* NB: These are exposed through /proc/scsi/scsi and form part of the ABI.
* You may not alter any existing entry (although adding new ones is
* encouraged once assigned by ANSI/INCITS T10
*/
static const char *const scsi_device_types[] = {
"Direct access ",
"Sequential access",
"Direct-Access ",
"Sequential-Access",
"Printer ",
"Processor ",
"WORM ",
"CD/DVD ",
"CD-ROM ",
"Scanner ",
"Optical memory ",
"Media changer ",
"Optical Device ",
"Medium Changer ",
"Communications ",
"ASC IT8 ",
"ASC IT8 ",
"RAID ",
"Enclosure ",
"Direct access RBC",
"Direct-Access-RBC",
"Optical card ",
"Bridge controller",
"Object storage ",
Expand Down

0 comments on commit 8a1cdc9

Please sign in to comment.