Skip to content

Commit

Permalink
make /proc/acpi/ac_adapter dependent on ACPI_PROCFS
Browse files Browse the repository at this point in the history
Do not provide /proc/acpi/ac_adapter if ACPI_PROCFS is not defined.  This
eliminates duplicated power adapters in HAL and makes it consistent with
battery module

Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
Acked-by: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Andrey Borzenkov authored and Linus Torvalds committed Nov 15, 2007
1 parent f961598 commit 8a246ee
Showing 1 changed file with 22 additions and 1 deletion.
23 changes: 22 additions & 1 deletion drivers/acpi/ac.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@
#include <linux/module.h>
#include <linux/init.h>
#include <linux/types.h>
#ifdef CONFIG_ACPI_PROCFS
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
#endif
#include <linux/power_supply.h>
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
Expand All @@ -49,12 +51,14 @@ MODULE_AUTHOR("Paul Diefenbaugh");
MODULE_DESCRIPTION("ACPI AC Adapter Driver");
MODULE_LICENSE("GPL");

#ifdef CONFIG_ACPI_PROCFS
extern struct proc_dir_entry *acpi_lock_ac_dir(void);
extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);
#endif

static int acpi_ac_add(struct acpi_device *device);
static int acpi_ac_remove(struct acpi_device *device, int type);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);

const static struct acpi_device_id ac_device_ids[] = {
{"ACPI0003", 0},
Expand All @@ -80,12 +84,15 @@ struct acpi_ac {

#define to_acpi_ac(x) container_of(x, struct acpi_ac, charger);

#ifdef CONFIG_ACPI_PROCFS
static const struct file_operations acpi_ac_fops = {
.open = acpi_ac_open_fs,
.read = seq_read,
.llseek = seq_lseek,
.release = single_release,
};
#endif

static int get_ac_property(struct power_supply *psy,
enum power_supply_property psp,
union power_supply_propval *val)
Expand Down Expand Up @@ -127,6 +134,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac)
return 0;
}

#ifdef CONFIG_ACPI_PROCFS
/* --------------------------------------------------------------------------
FS Interface (/proc)
-------------------------------------------------------------------------- */
Expand Down Expand Up @@ -206,6 +214,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device)

return 0;
}
#endif

/* --------------------------------------------------------------------------
Driver Model
Expand Down Expand Up @@ -264,7 +273,9 @@ static int acpi_ac_add(struct acpi_device *device)
if (result)
goto end;

#ifdef CONFIG_ACPI_PROCFS
result = acpi_ac_add_fs(device);
#endif
if (result)
goto end;
ac->charger.name = acpi_device_bid(device);
Expand All @@ -287,7 +298,9 @@ static int acpi_ac_add(struct acpi_device *device)

end:
if (result) {
#ifdef CONFIG_ACPI_PROCFS
acpi_ac_remove_fs(device);
#endif
kfree(ac);
}

Expand All @@ -309,7 +322,9 @@ static int acpi_ac_remove(struct acpi_device *device, int type)
ACPI_ALL_NOTIFY, acpi_ac_notify);
if (ac->charger.dev)
power_supply_unregister(&ac->charger);
#ifdef CONFIG_ACPI_PROCFS
acpi_ac_remove_fs(device);
#endif

kfree(ac);

Expand All @@ -323,13 +338,17 @@ static int __init acpi_ac_init(void)
if (acpi_disabled)
return -ENODEV;

#ifdef CONFIG_ACPI_PROCFS
acpi_ac_dir = acpi_lock_ac_dir();
if (!acpi_ac_dir)
return -ENODEV;
#endif

result = acpi_bus_register_driver(&acpi_ac_driver);
if (result < 0) {
#ifdef CONFIG_ACPI_PROCFS
acpi_unlock_ac_dir(acpi_ac_dir);
#endif
return -ENODEV;
}

Expand All @@ -341,7 +360,9 @@ static void __exit acpi_ac_exit(void)

acpi_bus_unregister_driver(&acpi_ac_driver);

#ifdef CONFIG_ACPI_PROCFS
acpi_unlock_ac_dir(acpi_ac_dir);
#endif

return;
}
Expand Down

0 comments on commit 8a246ee

Please sign in to comment.