Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 206817
b: refs/heads/master
c: c374ab4
h: refs/heads/master
i:
  206815: b77f95a
v: v3
  • Loading branch information
Clemens Ladisch committed Jun 10, 2010
1 parent c96b6ea commit 8a2fd87
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e91b2787d0a2e4719b016e8dec0afd2d5ab6c30f
refs/heads/master: c374ab424249b6ab91b1aee7460419d3f2c321df
26 changes: 19 additions & 7 deletions trunk/drivers/firewire/core-card.c
Original file line number Diff line number Diff line change
Expand Up @@ -369,10 +369,8 @@ static void fw_card_bm_work(struct work_struct *work)
goto out;
} else if (root_device_is_cmc) {
/*
* FIXME: I suppose we should set the cmstr bit in the
* STATE_CLEAR register of this node, as described in
* 1394-1995, 8.4.2.6. Also, send out a force root
* packet for this node.
* We will send out a force root packet for this
* node as part of the gap count optimization.
*/
new_root_id = root_id;
} else {
Expand Down Expand Up @@ -413,11 +411,25 @@ static void fw_card_bm_work(struct work_struct *work)
fw_send_phy_config(card, new_root_id, generation, gap_count);
fw_core_initiate_bus_reset(card, 1);
/* Will allocate broadcast channel after the reset. */
} else {
if (local_id == irm_id)
allocate_broadcast_channel(card, generation);
goto out;
}

if (root_device_is_cmc) {
/*
* Make sure that the cycle master sends cycle start packets.
*/
card->bm_transaction_data[0] = cpu_to_be32(CSR_STATE_BIT_CMSTR);
rcode = fw_run_transaction(card, TCODE_WRITE_QUADLET_REQUEST,
root_id, generation, SCODE_100,
CSR_REGISTER_BASE + CSR_STATE_SET,
card->bm_transaction_data, sizeof(u32));
if (rcode == RCODE_GENERATION)
goto out;
}

if (local_id == irm_id)
allocate_broadcast_channel(card, generation);

out:
fw_node_put(root_node);
out_put_card:
Expand Down

0 comments on commit 8a2fd87

Please sign in to comment.