Skip to content

Commit

Permalink
[PATCH] cpuset use combined atomic_inc_return calls
Browse files Browse the repository at this point in the history
Replace pairs of calls to <atomic_inc, atomic_read>, with a single call
atomic_inc_return, saving a few bytes of source and kernel text.

Signed-off-by: Paul Jackson <pj@sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Paul Jackson authored and Linus Torvalds committed Mar 24, 2006
1 parent 7b5b9ef commit 8a39cc6
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions kernel/cpuset.c
Original file line number Diff line number Diff line change
Expand Up @@ -858,8 +858,7 @@ static int update_nodemask(struct cpuset *cs, char *buf)

mutex_lock(&callback_mutex);
cs->mems_allowed = trialcs.mems_allowed;
atomic_inc(&cpuset_mems_generation);
cs->mems_generation = atomic_read(&cpuset_mems_generation);
cs->mems_generation = atomic_inc_return(&cpuset_mems_generation);
mutex_unlock(&callback_mutex);

set_cpuset_being_rebound(cs); /* causes mpol_copy() rebind */
Expand Down Expand Up @@ -1770,8 +1769,7 @@ static long cpuset_create(struct cpuset *parent, const char *name, int mode)
atomic_set(&cs->count, 0);
INIT_LIST_HEAD(&cs->sibling);
INIT_LIST_HEAD(&cs->children);
atomic_inc(&cpuset_mems_generation);
cs->mems_generation = atomic_read(&cpuset_mems_generation);
cs->mems_generation = atomic_inc_return(&cpuset_mems_generation);
fmeter_init(&cs->fmeter);

cs->parent = parent;
Expand Down Expand Up @@ -1861,7 +1859,7 @@ int __init cpuset_init_early(void)
struct task_struct *tsk = current;

tsk->cpuset = &top_cpuset;
tsk->cpuset->mems_generation = atomic_read(&cpuset_mems_generation);
tsk->cpuset->mems_generation = atomic_inc_return(&cpuset_mems_generation);
return 0;
}

Expand All @@ -1880,8 +1878,7 @@ int __init cpuset_init(void)
top_cpuset.mems_allowed = NODE_MASK_ALL;

fmeter_init(&top_cpuset.fmeter);
atomic_inc(&cpuset_mems_generation);
top_cpuset.mems_generation = atomic_read(&cpuset_mems_generation);
top_cpuset.mems_generation = atomic_inc_return(&cpuset_mems_generation);

init_task.cpuset = &top_cpuset;

Expand Down

0 comments on commit 8a39cc6

Please sign in to comment.