Skip to content

Commit

Permalink
ACPI / resources: Use AE_CTRL_TERMINATE to terminate resources walks
Browse files Browse the repository at this point in the history
Currently acpi_dev_process_resource() returns AE_ABORT_METHOD
to terminate the acpi_walk_resources() it is called from if
the .preproc() routine provided by the caller of
acpi_dev_get_resources() initiating the resources walk returns
an error code.  It is better to use AE_CTRL_TERMINATE for this
purpose, however, so do that.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
  • Loading branch information
Rafael J. Wysocki committed Nov 16, 2012
1 parent 8e345c9 commit 8a66790
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/acpi/resource.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ static acpi_status acpi_dev_process_resource(struct acpi_resource *ares,
ret = c->preproc(ares, c->preproc_data);
if (ret < 0) {
c->error = ret;
return AE_ABORT_METHOD;
return AE_CTRL_TERMINATE;
} else if (ret > 0) {
return AE_OK;
}
Expand Down

0 comments on commit 8a66790

Please sign in to comment.