Skip to content

Commit

Permalink
RealView: Use flush_cache_all() rather than MCR in cpu_enter_lowpower()
Browse files Browse the repository at this point in the history
The MCR for flushing the whole D cache is undefined on ARMv7 CPUs.

Signed-off-by: Harry Fearnhamm <Harry.Fearnhamm@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
  • Loading branch information
Harry Fearnhamm authored and Catalin Marinas committed Dec 1, 2008
1 parent e7c7082 commit 8aa2da8
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion arch/arm/mach-realview/hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
#include <linux/smp.h>
#include <linux/completion.h>

#include <asm/cacheflush.h>

extern volatile int pen_release;

static DECLARE_COMPLETION(cpu_killed);
Expand All @@ -21,7 +23,8 @@ static inline void cpu_enter_lowpower(void)
{
unsigned int v;

asm volatile( "mcr p15, 0, %1, c7, c14, 0\n"
flush_cache_all();
asm volatile(
" mcr p15, 0, %1, c7, c5, 0\n"
" mcr p15, 0, %1, c7, c10, 4\n"
/*
Expand Down

0 comments on commit 8aa2da8

Please sign in to comment.