Skip to content

Commit

Permalink
backlight: tosa: fix checkpatch error and warning
Browse files Browse the repository at this point in the history 
This patch fixes the checkpatch error and warning as below:

  ERROR: spaces required around that '?' (ctx:VxW)
  ERROR: space required after that ',' (ctx:VxV)

Also, unnecessary lines are removed.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jingoo Han authored and Linus Torvalds committed Dec 18, 2012
1 parent 97d9655 commit 8ab77f4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 8 deletions.
1 change: 0 additions & 1 deletion drivers/video/backlight/tosa_bl.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ static const struct i2c_device_id tosa_bl_id[] = {
{ },
};


static struct i2c_driver tosa_bl_driver = {
.driver = {
.name = "tosa-bl",
Expand Down
16 changes: 9 additions & 7 deletions drivers/video/backlight/tosa_lcd.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ static int tosa_tg_send(struct spi_device *spi, int adrs, uint8_t data)
int tosa_bl_enable(struct spi_device *spi, int enable)
{
/* bl_enable GP04=1 otherwise GP04=0*/
return tosa_tg_send(spi, TG_GPODR2, enable? 0x01 : 0x00);
return tosa_tg_send(spi, TG_GPODR2, enable ? 0x01 : 0x00);
}
EXPORT_SYMBOL(tosa_bl_enable);

Expand Down Expand Up @@ -91,15 +91,17 @@ static void tosa_lcd_tg_on(struct tosa_lcd_data *data)
tosa_tg_send(spi, TG_PNLCTL, value);

/* TG LCD pannel power up */
tosa_tg_send(spi, TG_PINICTL,0x4);
tosa_tg_send(spi, TG_PINICTL, 0x4);
mdelay(50);

/* TG LCD GVSS */
tosa_tg_send(spi, TG_PINICTL,0x0);
tosa_tg_send(spi, TG_PINICTL, 0x0);

if (!data->i2c) {
/* after the pannel is powered up the first time, we can access the i2c bus */
/* so probe for the DAC */
/*
* after the pannel is powered up the first time,
* we can access the i2c bus so probe for the DAC
*/
struct i2c_adapter *adap = i2c_get_adapter(0);
struct i2c_board_info info = {
.type = "tosa-bl",
Expand All @@ -115,11 +117,11 @@ static void tosa_lcd_tg_off(struct tosa_lcd_data *data)
struct spi_device *spi = data->spi;

/* TG LCD VHSA off */
tosa_tg_send(spi, TG_PINICTL,0x4);
tosa_tg_send(spi, TG_PINICTL, 0x4);
mdelay(50);

/* TG LCD signal off */
tosa_tg_send(spi, TG_PINICTL,0x6);
tosa_tg_send(spi, TG_PINICTL, 0x6);
mdelay(50);

/* TG Off */
Expand Down

0 comments on commit 8ab77f4

Please sign in to comment.