Skip to content

Commit

Permalink
[PATCH] ppc64: Quieten lparcfg
Browse files Browse the repository at this point in the history
If we dont have permission to read some information from the hypervisor,
lparcfg outputs a warning on the console. Now that lparcfg is world
readable this is a problem.

Dont warn in the case of H_Authority, remove some unnecessary function
prototypes and fix whitespace damage in a structure as well.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Anton Blanchard authored and Paul Mackerras committed Nov 11, 2005
1 parent 7f7fda0 commit 8acb888
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions arch/powerpc/kernel/lparcfg.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
/* #define LPARCFG_DEBUG */

/* find a better place for this function... */
void log_plpar_hcall_return(unsigned long rc, char *tag)
static void log_plpar_hcall_return(unsigned long rc, char *tag)
{
if (rc == 0) /* success, return */
return;
Expand Down Expand Up @@ -213,11 +213,10 @@ static void h_pic(unsigned long *pool_idle_time, unsigned long *num_procs)
unsigned long dummy;
rc = plpar_hcall(H_PIC, 0, 0, 0, 0, pool_idle_time, num_procs, &dummy);

log_plpar_hcall_return(rc, "H_PIC");
if (rc != H_Authority)
log_plpar_hcall_return(rc, "H_PIC");
}

static unsigned long get_purr(void);

/* Track sum of all purrs across all processors. This is used to further */
/* calculate usage values by different applications */

Expand Down Expand Up @@ -319,8 +318,6 @@ static void parse_system_parameter_string(struct seq_file *m)
kfree(local_buffer);
}

static int lparcfg_count_active_processors(void);

/* Return the number of processors in the system.
* This function reads through the device tree and counts
* the virtual processors, this does not include threads.
Expand Down Expand Up @@ -548,7 +545,7 @@ static ssize_t lparcfg_write(struct file *file, const char __user * buf,
retval = -EIO;
}

out:
out:
kfree(kbuf);
return retval;
}
Expand All @@ -561,10 +558,10 @@ static int lparcfg_open(struct inode *inode, struct file *file)
}

struct file_operations lparcfg_fops = {
.owner = THIS_MODULE,
.read = seq_read,
.open = lparcfg_open,
.release = single_release,
.owner = THIS_MODULE,
.read = seq_read,
.open = lparcfg_open,
.release = single_release,
};

int __init lparcfg_init(void)
Expand Down

0 comments on commit 8acb888

Please sign in to comment.