Skip to content

Commit

Permalink
serial: MIPS: lantiq: fix clock error check
Browse files Browse the repository at this point in the history
The clock should be checked with the proper IS_ERR() api before using it.

Signed-off-by: John Crispin <blogic@openwrt.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
John Crispin authored and Greg Kroah-Hartman committed Aug 12, 2013
1 parent 7c658e6 commit 8ad2ee9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/tty/serial/lantiq.c
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ lqasc_startup(struct uart_port *port)
struct ltq_uart_port *ltq_port = to_ltq_uart_port(port);
int retval;

if (ltq_port->clk)
if (!IS_ERR(ltq_port->clk))
clk_enable(ltq_port->clk);
port->uartclk = clk_get_rate(ltq_port->fpiclk);

Expand Down Expand Up @@ -386,7 +386,7 @@ lqasc_shutdown(struct uart_port *port)
port->membase + LTQ_ASC_RXFCON);
ltq_w32_mask(ASCTXFCON_TXFEN, ASCTXFCON_TXFFLU,
port->membase + LTQ_ASC_TXFCON);
if (ltq_port->clk)
if (!IS_ERR(ltq_port->clk))
clk_disable(ltq_port->clk);
}

Expand Down

0 comments on commit 8ad2ee9

Please sign in to comment.