Skip to content

Commit

Permalink
[PATCH] as-iosched: remove state assertion in as_add_request()
Browse files Browse the repository at this point in the history
Kill the arq->state poison statement in as_add_request(), it can trigger
for perfectly valid code that just reuses a request after io completion
instead of freeing it and allocating a new one. We probably should
introduce a blk_init_request() to start from scratch, but for now just
kill it as we will be removing the as specific poisoning soon.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Jens Axboe authored and Linus Torvalds committed Nov 21, 2005
1 parent f9e6bfa commit 8ad9ebb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions block/as-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1371,10 +1371,6 @@ static void as_add_request(request_queue_t *q, struct request *rq)
struct as_rq *alias;
int data_dir;

if (arq->state != AS_RQ_PRESCHED) {
printk("arq->state: %d\n", arq->state);
WARN_ON(1);
}
arq->state = AS_RQ_NEW;

if (rq_data_dir(arq->request) == READ
Expand Down

0 comments on commit 8ad9ebb

Please sign in to comment.