Skip to content

Commit

Permalink
[PATCH] powerpc: udbg_printf() formatting attribute
Browse files Browse the repository at this point in the history
This patch allows the compiler to catch any printf-like mismatches for
udbg_printf().  After some brute force building I've only found issues
with my own code and lparcfg.c It could break some developers, but
IMHO that would be goodness.

Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
jimix@watson.ibm.com authored and Paul Mackerras committed May 19, 2006
1 parent 35dd543 commit 8ae5b28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions arch/powerpc/kernel/lparcfg.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,10 +521,10 @@ static ssize_t lparcfg_write(struct file *file, const char __user * buf,

current_weight = (resource >> 5 * 8) & 0xFF;

pr_debug("%s: current_entitled = %lu, current_weight = %lu\n",
pr_debug("%s: current_entitled = %lu, current_weight = %u\n",
__FUNCTION__, current_entitled, current_weight);

pr_debug("%s: new_entitled = %lu, new_weight = %lu\n",
pr_debug("%s: new_entitled = %lu, new_weight = %u\n",
__FUNCTION__, *new_entitled_ptr, *new_weight_ptr);

retval = plpar_hcall_norets(H_SET_PPP, *new_entitled_ptr,
Expand Down
3 changes: 2 additions & 1 deletion include/asm-powerpc/udbg.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ extern int udbg_write(const char *s, int n);
extern int udbg_read(char *buf, int buflen);

extern void register_early_udbg_console(void);
extern void udbg_printf(const char *fmt, ...);
extern void udbg_printf(const char *fmt, ...)
__attribute__ ((format (printf, 1, 2)));
extern void udbg_progress(char *s, unsigned short hex);

extern void udbg_init_uart(void __iomem *comport, unsigned int speed,
Expand Down

0 comments on commit 8ae5b28

Please sign in to comment.