Skip to content

Commit

Permalink
ext4: Remove duplicate call to ext4_commit_super() in ext4_freeze()
Browse files Browse the repository at this point in the history
Commit c4be0c1 added error checking to ext4_freeze() when calling
ext4_commit_super().  Unfortunately the patch failed to remove the
original call to ext4_commit_super(), with the net result that when
freezing the filesystem, the superblock gets written twice, the first
time without error checking.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  • Loading branch information
Theodore Ts'o committed Feb 28, 2009
1 parent ebd3610 commit 8b1a8ff
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion fs/ext4/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -3091,7 +3091,6 @@ static int ext4_freeze(struct super_block *sb)

/* Journal blocked and flushed, clear needs_recovery flag. */
EXT4_CLEAR_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_RECOVER);
ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1);
error = ext4_commit_super(sb, EXT4_SB(sb)->s_es, 1);
if (error)
goto out;
Expand Down

0 comments on commit 8b1a8ff

Please sign in to comment.