Skip to content

Commit

Permalink
Btrfs: fix memory leak in btrfs_ioctl_start_sync()
Browse files Browse the repository at this point in the history
Call btrfs_end_transaction() if btrfs_commit_transaction_async() fails.

Signed-off-by: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
  • Loading branch information
Tsutomu Itoh authored and Chris Mason committed Apr 5, 2011
1 parent b44c59a commit 8b2b2d3
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion fs/btrfs/ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -2436,8 +2436,10 @@ static noinline long btrfs_ioctl_start_sync(struct file *file, void __user *argp
return PTR_ERR(trans);
transid = trans->transid;
ret = btrfs_commit_transaction_async(trans, root, 0);
if (ret)
if (ret) {
btrfs_end_transaction(trans, root);
return ret;
}

if (argp)
if (copy_to_user(argp, &transid, sizeof(transid)))
Expand Down

0 comments on commit 8b2b2d3

Please sign in to comment.