Skip to content

Commit

Permalink
HID: primax: Remove px_probe() and px_remove() functions
Browse files Browse the repository at this point in the history
The px_probe() and px_remove() functions do not have any special initialization
and cleanup. Remove them and let HID core handle the default probe/remove
actions.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
  • Loading branch information
Axel Lin authored and Jiri Kosina committed Sep 7, 2012
1 parent 751e5ed commit 8b61513
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions drivers/hid/hid-primax.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,29 +64,6 @@ static int px_raw_event(struct hid_device *hid, struct hid_report *report,
return 0;
}

static int px_probe(struct hid_device *hid, const struct hid_device_id *id)
{
int ret;

ret = hid_parse(hid);
if (ret) {
hid_err(hid, "parse failed\n");
goto fail;
}

ret = hid_hw_start(hid, HID_CONNECT_DEFAULT);
if (ret)
hid_err(hid, "hw start failed\n");

fail:
return ret;
}

static void px_remove(struct hid_device *hid)
{
hid_hw_stop(hid);
}

static const struct hid_device_id px_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_PRIMAX, USB_DEVICE_ID_PRIMAX_KEYBOARD) },
{ }
Expand All @@ -97,8 +74,6 @@ static struct hid_driver px_driver = {
.name = "primax",
.id_table = px_devices,
.raw_event = px_raw_event,
.probe = px_probe,
.remove = px_remove,
};

static int __init px_init(void)
Expand Down

0 comments on commit 8b61513

Please sign in to comment.