Skip to content

Commit

Permalink
softirq: remove useless function __local_bh_enable
Browse files Browse the repository at this point in the history
Impact: remove unused code

__local_bh_enable has been replaced with _local_bh_enable.
As comments says "it always nests inside local_bh_enable() sections"
has not been valid now. Also there is no reason to use __local_bh_enable
anywhere, so we can remove this useless function.

Signed-off-by: Liming Wang <liming.wang@windriver.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Liming Wang authored and Ingo Molnar committed Nov 28, 2008
1 parent ed31348 commit 8b752e3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion include/linux/bottom_half.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#define _LINUX_BH_H

extern void local_bh_disable(void);
extern void __local_bh_enable(void);
extern void _local_bh_enable(void);
extern void local_bh_enable(void);
extern void local_bh_enable_ip(unsigned long ip);
Expand Down
14 changes: 0 additions & 14 deletions kernel/softirq.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,6 @@ void local_bh_disable(void)

EXPORT_SYMBOL(local_bh_disable);

void __local_bh_enable(void)
{
WARN_ON_ONCE(in_irq());

/*
* softirqs should never be enabled by __local_bh_enable(),
* it always nests inside local_bh_enable() sections:
*/
WARN_ON_ONCE(softirq_count() == SOFTIRQ_OFFSET);

sub_preempt_count(SOFTIRQ_OFFSET);
}
EXPORT_SYMBOL_GPL(__local_bh_enable);

/*
* Special-case - softirqs can safely be enabled in
* cond_resched_softirq(), or by __do_softirq(),
Expand Down

0 comments on commit 8b752e3

Please sign in to comment.