Skip to content

Commit

Permalink
oprofile: don't request cache line alignment for cpu_buffer
Browse files Browse the repository at this point in the history
Alignment was previously requested because cpu_buffer was an [NR_CPUS]
array, to avoid cache line sharing between CPUS.

After commit 608dfdd (oprofile: change
cpu_buffer from array to per_cpu variable ), we dont need to force an
alignement anymore since cpu_buffer sits in per_cpu zone.

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Cc: Mike Travis <travis@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Eric Dumazet authored and Linus Torvalds committed May 15, 2008
1 parent f7c5a77 commit 8b8b498
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/oprofile/cpu_buffer.c
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "buffer_sync.h"
#include "oprof.h"

DEFINE_PER_CPU_SHARED_ALIGNED(struct oprofile_cpu_buffer, cpu_buffer);
DEFINE_PER_CPU(struct oprofile_cpu_buffer, cpu_buffer);

static void wq_sync_buffer(struct work_struct *work);

Expand Down
2 changes: 1 addition & 1 deletion drivers/oprofile/cpu_buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ struct oprofile_cpu_buffer {
unsigned long sample_invalid_eip;
int cpu;
struct delayed_work work;
} ____cacheline_aligned;
};

DECLARE_PER_CPU(struct oprofile_cpu_buffer, cpu_buffer);

Expand Down

0 comments on commit 8b8b498

Please sign in to comment.