Skip to content

Commit

Permalink
perf top: Remove redundant syme->origin field
Browse files Browse the repository at this point in the history
We can get it from syme->map->dso->kernel (that should be renamed to
origin, but leave this for another patch).

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Arnaldo Carvalho de Melo committed Mar 11, 2011
1 parent ec52d97 commit 8b8ba4a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion tools/perf/builtin-top.c
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,6 @@ static void perf_event__process_sample(const union perf_event *event,
if (!syme->skip) {
struct perf_evsel *evsel;

syme->origin = origin;
evsel = perf_evlist__id2evsel(top.evlist, sample->id);
assert(evsel != NULL);
syme->count[evsel->idx]++;
Expand Down
4 changes: 2 additions & 2 deletions tools/perf/util/top.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,9 @@ float perf_top__decay_samples(struct perf_top *top, struct rb_root *root)
if (syme->snap_count != 0) {

if ((top->hide_user_symbols &&
syme->origin == PERF_RECORD_MISC_USER) ||
syme->map->dso->kernel == DSO_TYPE_USER) ||
(top->hide_kernel_symbols &&
syme->origin == PERF_RECORD_MISC_KERNEL)) {
syme->map->dso->kernel == DSO_TYPE_KERNEL)) {
perf_top__remove_active_sym(top, syme);
continue;
}
Expand Down
1 change: 0 additions & 1 deletion tools/perf/util/top.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ struct sym_entry {
unsigned long snap_count;
double weight;
int skip;
u8 origin;
struct map *map;
unsigned long count[0];
};
Expand Down

0 comments on commit 8b8ba4a

Please sign in to comment.