Skip to content

Commit

Permalink
platform / x86: Use global PCI rescan-remove locking
Browse files Browse the repository at this point in the history
Multiple race conditions are possible between the rfkill hotplug in the
asus-wmi and eeepc-laptop drivers and the generic PCI bus rescan and device
removal that can be triggered via sysfs.

To avoid those race conditions make asus-wmi and eeepc-laptop use global
PCI rescan-remove locking around the rfkill hotplug.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Rafael J. Wysocki authored and Bjorn Helgaas committed Jan 14, 2014
1 parent c4ec84c commit 8b9ec1d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/platform/x86/asus-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,7 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus)
mutex_unlock(&asus->wmi_lock);

mutex_lock(&asus->hotplug_lock);
pci_lock_rescan_remove();

if (asus->wlan.rfkill)
rfkill_set_sw_state(asus->wlan.rfkill, blocked);
Expand Down Expand Up @@ -656,6 +657,7 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus)
}

out_unlock:
pci_unlock_rescan_remove();
mutex_unlock(&asus->hotplug_lock);
}

Expand Down
2 changes: 2 additions & 0 deletions drivers/platform/x86/eeepc-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
rfkill_set_sw_state(eeepc->wlan_rfkill, blocked);

mutex_lock(&eeepc->hotplug_lock);
pci_lock_rescan_remove();

if (eeepc->hotplug_slot) {
port = acpi_get_pci_dev(handle);
Expand Down Expand Up @@ -649,6 +650,7 @@ static void eeepc_rfkill_hotplug(struct eeepc_laptop *eeepc, acpi_handle handle)
}

out_unlock:
pci_unlock_rescan_remove();
mutex_unlock(&eeepc->hotplug_lock);
}

Expand Down

0 comments on commit 8b9ec1d

Please sign in to comment.