Skip to content

Commit

Permalink
sound: fix check for return value in snd_pcm_hw_refine
Browse files Browse the repository at this point in the history
'params' is a pointer and looking at the code this probably should be a check
for ioctl return value.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Mariusz Kozlowski authored and Takashi Iwai committed Jun 22, 2009
1 parent 4f64e15 commit 8bd9bca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/core/pcm_native.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
changed = substream->ops->ioctl(substream,
SNDRV_PCM_IOCTL1_FIFO_SIZE, params);
if (params < 0)
if (changed < 0)
return changed;
}
}
Expand Down

0 comments on commit 8bd9bca

Please sign in to comment.