Skip to content

Commit

Permalink
intel-iommu mistakenly uses offset_pfn when caching mode is enabled
Browse files Browse the repository at this point in the history
intel_map_sg used offset_pfn which was set to zero when invalidating the IOTLB.
intel_map_sg now uses size variable for this matter.

Signed-off-by: Nadav Amit <nadav.amit@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Nadav Amit authored and David Woodhouse committed Apr 9, 2010
1 parent a45946a commit 8bdd77d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/pci/intel-iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -2860,7 +2860,6 @@ static int intel_map_sg(struct device *hwdev, struct scatterlist *sglist, int ne
struct dmar_domain *domain;
size_t size = 0;
int prot = 0;
size_t offset_pfn = 0;
struct iova *iova = NULL;
int ret;
struct scatterlist *sg;
Expand Down Expand Up @@ -2914,7 +2913,7 @@ static int intel_map_sg(struct device *hwdev, struct scatterlist *sglist, int ne

/* it's a non-present to present mapping. Only flush if caching mode */
if (cap_caching_mode(iommu->cap))
iommu_flush_iotlb_psi(iommu, 0, start_vpfn, offset_pfn);
iommu_flush_iotlb_psi(iommu, 0, start_vpfn, size);
else
iommu_flush_write_buffer(iommu);

Expand Down

0 comments on commit 8bdd77d

Please sign in to comment.