Skip to content

Commit

Permalink
ixgbe: Fix 82598 MSI-X allocation on systems with more than 8 CPU cores
Browse files Browse the repository at this point in the history
MSI-X allocation broke after the 82599 merge on systems with more than 8
CPU cores.  82598 drops back into MSI mode, which isn't sufficient to run
full, efficient 10G line rate.

Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
PJ Waskiewicz authored and David S. Miller committed Apr 2, 2009
1 parent cd7664f commit 8be0e46
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions drivers/net/ixgbe/ixgbe_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2934,6 +2934,7 @@ static int ixgbe_alloc_queues(struct ixgbe_adapter *adapter)
**/
static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
{
struct ixgbe_hw *hw = &adapter->hw;
int err = 0;
int vector, v_budget;

Expand All @@ -2948,12 +2949,12 @@ static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)

/*
* At the same time, hardware can only support a maximum of
* MAX_MSIX_COUNT vectors. With features such as RSS and VMDq,
* we can easily reach upwards of 64 Rx descriptor queues and
* 32 Tx queues. Thus, we cap it off in those rare cases where
* the cpu count also exceeds our vector limit.
* hw.mac->max_msix_vectors vectors. With features
* such as RSS and VMDq, we can easily surpass the number of Rx and Tx
* descriptor queues supported by our device. Thus, we cap it off in
* those rare cases where the cpu count also exceeds our vector limit.
*/
v_budget = min(v_budget, MAX_MSIX_COUNT);
v_budget = min(v_budget, (int)hw->mac.max_msix_vectors);

/* A failure in MSI-X entry allocation isn't fatal, but it does
* mean we disable MSI-X capabilities of the adapter. */
Expand Down

0 comments on commit 8be0e46

Please sign in to comment.