Skip to content

Commit

Permalink
ixgbe: turn NETIF_F_HW_L2FW_DOFFLOAD off by default
Browse files Browse the repository at this point in the history
NETIF_F_HW_L2FW_DOFFLOAD allows upper layer net devices such
as macvlan to use queues in the hardware to directly submit and
receive skbs.

This creates a subtle change in the datapath though. One change
being the skb may no longer use the root devices qdisc.

Because users may not expect this we can't enable the feature
by default unless the hardware can offload all the software
functionality above it. So for now disable it by default and
let users opt in.

Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
  • Loading branch information
John Fastabend authored and Jeff Kirsher committed Nov 30, 2013
1 parent ae72c8d commit 8bf1264
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -7986,10 +7986,9 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
NETIF_F_TSO |
NETIF_F_TSO6 |
NETIF_F_RXHASH |
NETIF_F_RXCSUM |
NETIF_F_HW_L2FW_DOFFLOAD;
NETIF_F_RXCSUM;

netdev->hw_features = netdev->features;
netdev->hw_features = netdev->features | NETIF_F_HW_L2FW_DOFFLOAD;

switch (adapter->hw.mac.type) {
case ixgbe_mac_82599EB:
Expand Down

0 comments on commit 8bf1264

Please sign in to comment.