Skip to content

Commit

Permalink
[PATCH] powerpc: Make sure we don't create empty lmb regions
Browse files Browse the repository at this point in the history
To prevent problems later in boot, make sure we don't create zero-size lmb
regions.

I've checked all the callers, and at the moment no one should ever hit this.
All callers use a constant size, or they check the computed size before they
call us.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Michael Ellerman authored and Paul Mackerras committed Feb 7, 2006
1 parent fa93895 commit 8c20faf
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arch/powerpc/mm/lmb.c
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ long __init lmb_reserve(unsigned long base, unsigned long size)
{
struct lmb_region *_rgn = &(lmb.reserved);

BUG_ON(0 == size);

return lmb_add_region(_rgn, base, size);
}

Expand Down Expand Up @@ -227,6 +229,8 @@ unsigned long __init lmb_alloc_base(unsigned long size, unsigned long align,
long i, j;
unsigned long base = 0;

BUG_ON(0 == size);

#ifdef CONFIG_PPC32
/* On 32-bit, make sure we allocate lowmem */
if (max_addr == LMB_ALLOC_ANYWHERE)
Expand Down

0 comments on commit 8c20faf

Please sign in to comment.