Skip to content

Commit

Permalink
ASoC: ux500_pcm: No need to wrap snd_dmaengine_pcm_close()
Browse files Browse the repository at this point in the history
If a PCM driver using the dmaengine PCM helper functions doesn't need to do
anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
directly for as the pcm_close callback and there is no need to wrap it in a
custom function.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Ola Lilja <ola.o.lilja@stericsson.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Mar 26, 2013
1 parent 3021bd3 commit 8c4e56f
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions sound/soc/ux500/ux500_pcm.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,6 @@ static int ux500_pcm_open(struct snd_pcm_substream *substream)
return 0;
}

static int ux500_pcm_close(struct snd_pcm_substream *substream)
{
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_dai *dai = rtd->cpu_dai;

dev_dbg(dai->dev, "%s: Enter\n", __func__);

snd_dmaengine_pcm_close(substream);

return 0;
}

static int ux500_pcm_hw_params(struct snd_pcm_substream *substream,
struct snd_pcm_hw_params *hw_params)
{
Expand Down Expand Up @@ -246,7 +234,7 @@ static int ux500_pcm_mmap(struct snd_pcm_substream *substream,

static struct snd_pcm_ops ux500_pcm_ops = {
.open = ux500_pcm_open,
.close = ux500_pcm_close,
.close = snd_dmaengine_pcm_close,
.ioctl = snd_pcm_lib_ioctl,
.hw_params = ux500_pcm_hw_params,
.hw_free = ux500_pcm_hw_free,
Expand Down

0 comments on commit 8c4e56f

Please sign in to comment.